MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Mar 28, 2023
libminifi/include/core/state/nodes/RepositoryMetricsSourceStore.h
Outdated
Show resolved
Hide resolved
lordgamez
force-pushed
the
MINIFICPP-2082
branch
2 times, most recently
from
29f85d2
to
453104b
Compare
fgerlits
reviewed
Jun 6, 2023
adamdebreceni
approved these changes
Jun 7, 2023
fgerlits
approved these changes
Jun 8, 2023
szaszm
reviewed
Jun 15, 2023
martinzink
approved these changes
Jun 21, 2023
szaszm
reviewed
Jun 29, 2023
libminifi/src/core/state/nodes/RepositoryMetricsSourceStore.cpp
Outdated
Show resolved
Hide resolved
lordgamez
force-pushed
the
MINIFICPP-2082
branch
from
53b2a5c
to
f5b67d8
Compare
szaszm
approved these changes
Jul 6, 2023
fgerlits
pushed a commit
to fgerlits/nifi-minifi-cpp
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Ferenc Gerlits <[email protected]> This closes apache#1540
fgerlits
requested changes
Jul 11, 2023
There was a problem hiding this comment.
If I rebase this on top of the current main branch, then this test fails:
-------------------------------------------------------------------------------
Verify multiple metric nodes in logs
-------------------------------------------------------------------------------
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77
...............................................................................
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77: FAILED:
due to a fatal error condition:
SIGSEGV - Segmentation violation signal
lordgamez
force-pushed
the
MINIFICPP-2082
branch
from
f5b67d8
to
09d6029
Compare
Additional metrics were added for the rocksdb repositories in MINIFICPP-2022 which needs rocksdb repositories to be initialized to be able to open the rocksdb database and retrieve these metrics, which was missing in this PR. Fixed in 09d6029 |
fgerlits
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing the RocksDB specific metrics to the log file every 30 seconds, they are moved to the RepositoryMetrics. This way they can be published to any metric collector and should be able to print them to the log file as well periodically after MINIFICPP-2076 is merged.
Depends on MINIFICPP-2022
https://issues.apache.org/jira/browse/MINIFICPP-2082
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.